[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132043#comment-13132043
 ] 

jirapos...@reviews.apache.org commented on MAPREDUCE-3028:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2468/
-----------------------------------------------------------

(Updated 2011-10-20 21:09:33.246936)


Review request for Tom Graves, Robert Evans, Jonathan Eagles, and Mark 
Holderbaugh.


Changes
-------

- Incorporated review comments. Thanks Bobby and Mark.
- Added unit tests
- Removed JIRA number so as not to spam the JIRA


Summary
-------

Job end notification for 0.23 / next. I'm going to work on unit tests while you 
folks review the code.

The only new thing added to 0.20 is that multiple recipients can be configured 
to receive the job-end notification by supplying multiple URLs (one parameter 
separated by a regex)


Diffs (updated)
-----

  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java
 PRE-CREATION 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
 1186838 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestJobEndNotifier.java
 PRE-CREATION 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
 1186838 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobEndNotifier.java
 1186838 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
 1186838 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ConfigUtil.java
 1186838 
  
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
 1186838 

Diff: https://reviews.apache.org/r/2468/diff


Testing
-------

Manually tested changes on a single node cluster. Going to add unit tests.


Thanks,

Ravi


                
> Support job end notification in .next /0.23
> -------------------------------------------
>
>                 Key: MAPREDUCE-3028
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3028
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Ravi Prakash
>            Priority: Blocker
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-3028.branch-0.23.patch
>
>
> Oozie primarily depends on  the job end notification to determine when the 
> job finishes. In the current version,  job end notification is implemented in 
> job tracker. Since job tracker will be removed in the upcoming hadoop release 
> (.next), we wander where this support will move. I think this best effort 
> notification could be implemented in the new Application Manager as one of 
> the last step of job completion.
> Whatever implementation will it be, Oozie badly needs this feature to be 
> continued in next releases as well.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to