[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134225#comment-13134225
 ] 

Robert Joseph Evans commented on MAPREDUCE-2747:
------------------------------------------------

Thanks for the review.  I looked at your changes and they look good to me.  The 
-Pnative is only needed for trunk, but hopefully 0.23 will get those build 
script changes soon too.  Thanks for finding and fixing those issues with the 
native code/tests.  I don't think I changed any of the native tests/code 
execution when I renamed things, so I suspect that they may be issues in 
0.22/0.21 as well.

+1 (Non-binding)
                
> [MR-279] [Security] Cleanup LinuxContainerExecutor binary sources
> -----------------------------------------------------------------
>
>                 Key: MAPREDUCE-2747
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2747
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, nodemanager, security
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Robert Joseph Evans
>            Priority: Blocker
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: MAPREDUCE-2747-20111024.txt, MAPREDUCE-2747.patch, 
> MR-2747-branch-0.23.txt, MR-2747.txt, MR-2747.txt, MR-2747.txt
>
>
> There are a lot of references to the old task-controller nomenclature still, 
> job/task refs instead of app/container.
> Also the configuration file is named as taskcontroller.cfg and the configured 
> variables are also from the mapred world (mrv1). These SHOULD  be fixed 
> before we make a release. Marking this as blocker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to