[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144356#comment-13144356
 ] 

Mahadev konar commented on MAPREDUCE-3359:
------------------------------------------

Bobby,
 the patch looks fine. A minor nit, we should just add javadoc on 
setCancelTokensWhenComplete to make sure we warn users not to use it without 
reason. Something like:

WARNING: this is not recommended unless you want your single job tokens to be 
reused by others jobs (highly unlikely).

Couldnt come up with something better. Feel free to innovate! :)




                
> Yarn clients / AM should be able to provide config options to the RM / NM
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3359
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3359
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Siddharth Seth
>            Assignee: Robert Joseph Evans
>         Attachments: MR-3359.txt, MR-3359.txt
>
>
> The RM and NM do not read a job's configuration. Clients / AMs should however 
> be able to configure certain parameters for the RM/NM on a per app basis - 
> like the Log Retention policy, token cancellation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to