[
https://issues.apache.org/jira/browse/MAPREDUCE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146639#comment-13146639
]
Nathan Roberts commented on MAPREDUCE-3121:
-------------------------------------------
Took a look at the patch and current comments. I'll go through it again when
the next version becomes available. Mostly nits.
- Is log aggregator properly dealing with log directories going away?
- container-executor.h: @param comments should be adjusted, array of char
pointers can be const
- container-executor/impl/main.c - The argc checks for LAUNCH and SIGNAL seem
like they should be != checks instead of < checks. Also, the Usage statements
for INITIALIZE and LAUNCH use "tokens" instead of cred_file, pid_file.
- configuration.c - I think the realloc allocates more than necessary but you
didn't introduce this and it shouldn't introduce any problems under normal
circumstances. (The MAX_SIZE shouldn't be in that part of the calculation. It's
already compensated for in toPassSize.)
> NodeManager should handle disk-failures
> ---------------------------------------
>
> Key: MAPREDUCE-3121
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3121
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, nodemanager
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: 3121.patch
>
>
> This is akin to MAPREDUCE-2413 but for YARN's NodeManager. We want to
> minimize the impact of transient/permanent disk failures on containers. With
> larger number of disks per node, the ability to continue to run containers on
> other disks is crucial.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
