[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149602#comment-13149602
 ] 

Amar Kamat commented on MAPREDUCE-3375:
---------------------------------------

Vinay,
The assert statement
{noformat}
Assert.assertTrue("Simulated job's  map-task heap ratio did not match.", 
actHeapRatio <= expHeapRatio );
{noformat}
needs a fix. In most of the cases, {{actHeapRatio}} will be 0 as its a division 
between 2 longs. So firstly the statement
{noformat}
double actHeapRatio = simuJobMapsTHU / origJobMapsTHU;
{noformat}
should be 
{noformat}
double actHeapRatio = ((double)simuJobMapsTHU) / origJobMapsTHU;
{noformat}
 or something like that.

Secondly, the gap between the original and simulated tasks' heap memory usage 
should be checked and not the actual usages. Hence, the above mentioned formula 
now becomes
{noformat}
double actHeapRatio = ((double)Math.abs(origJobMapsTHU - simuJobMapsTHU)) / 
origJobMapsTHU;
{noformat}

Kindly make the modifications and re-run the system test. 
                
> Memory Emulation system tests.
> ------------------------------
>
>                 Key: MAPREDUCE-3375
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3375
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: MAPREDUCE-3375.v1.patch, MAPREDUCE-3375.v2.patch, 
> MAPREDUCE-3375.v3.patch, MAPREDUCE-3375.v4.patch
>
>
> 1. Test the Gridmix memory emulation feature for gridmix jobs with default 
> progress interval, different input data, submission policies and user 
> resolver modes . Verify the maps phase of total heap usage of gridmix jobs 
> with corresponding the original job in the trace.
> 2. Test the Gridmix memory emulation feature for gridmix jobs with custom 
> progress interval, different input data, submission policies and user 
> resolver modes . Verify the maps phase of total heap usage of gridmix jobs 
> with corresponding the original job in the trace.
> 3. Test the Gridmix memory emulation feature for gridmix jobs with default 
> progress interval, different input data, submission policies and user 
> resolver modes. Verify the maps and reduces phase of total heap usage metric 
> of gridmix jobs with corresponding the original job in the trace.
> 4. Disable Gridmix memory emulation option and verify the jobs whether it 
> emulates the heap memory or not.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to