[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149719#comment-13149719
 ] 

jirapos...@reviews.apache.org commented on MAPREDUCE-3328:
----------------------------------------------------------



bq.  On 2011-11-11 20:44:17, Jonathan Eagles wrote:
bq.  > looks good to me. i prefer parentqueue.childqueue notation instead of 
indentation format which i think will look better with deep queue hierarchies.

Thanks Jon! :) I'm leaning towards fixing the notation (parentqueue.childqueue) 
in MAPREDUCE-3147.


- Ravi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2804/#review3180
-----------------------------------------------------------


On 2011-11-11 15:53:53, Ravi Prakash wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2804/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-11 15:53:53)
bq.  
bq.  
bq.  Review request for Tom Graves, Robert Evans, Eric Payne, Jonathan Eagles, 
Mark Holderbaugh, and johnvijoe.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Output is like this now:
bq.  
bq.  ======================
bq.  Queue Name : boston 
bq.  Queue State : running 
bq.  Scheduling Info : Capacity: 25.0, MaximumCapacity: UNDEFINED, 
CurrentCapacity: 0.0 
bq.  ======================
bq.  Queue Name : default 
bq.  Queue State : running 
bq.  Scheduling Info : Capacity: 25.0, MaximumCapacity: UNDEFINED, 
CurrentCapacity: 0.0 
bq.  ======================
bq.  Queue Name : kansas 
bq.  Queue State : running 
bq.  Scheduling Info : Capacity: 25.0, MaximumCapacity: UNDEFINED, 
CurrentCapacity: 0.0 
bq.  ======================
bq.  Queue Name : styx 
bq.  Queue State : running 
bq.  Scheduling Info : Capacity: 25.0, MaximumCapacity: UNDEFINED, 
CurrentCapacity: 0.0 
bq.      ======================
bq.      Queue Name : boston 
bq.      Queue State : running 
bq.      Scheduling Info : Capacity: 50.0, MaximumCapacity: UNDEFINED, 
CurrentCapacity: 0.0 
bq.      ======================
bq.      Queue Name : kansas 
bq.      Queue State : running 
bq.      Scheduling Info : Capacity: 50.0, MaximumCapacity: UNDEFINED, 
CurrentCapacity: 0.0 
bq.  
bq.  (MaximumCapacity was undefined in my setup)
bq.  
bq.  
bq.  This addresses bug MAPREDUCE-3328.
bq.      https://issues.apache.org/jira/browse/MAPREDUCE-3328
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
 1200893 
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/TestTypeConverter.java
 1200893 
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueClient.java
 1200893 
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueInfo.java
 1200893 
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestJobQueueClient.java
 PRE-CREATION 
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
 1200893 
bq.    
branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestResourceMgrDelegate.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2804/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  - Unit tests ran.
bq.  - test-patch ran with +1. 
bq.  - command executed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ravi
bq.  
bq.


                
> mapred queue -list output inconsistent and missing child queues
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-3328
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3328
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Ravi Prakash
>            Priority: Critical
>         Attachments: MAPREDUCE-3328.branch-0.23.patch
>
>
> When running mapred queue -list on a 0.23.0 cluster with capacity scheduler 
> configured with child queues.  In my case I have queues default, test1, and 
> test2.  test1 has subqueues of a1, a2.  test2 has subqueues of a3 and a4.
> - the child queues do not show up
> - The output of maximum capacity doesn't match the format of the current 
> capacity and capacity.  the latter two use float while the maximum is 
> specified as int:
> Queue Name : default 
> Queue State : running 
> Scheduling Info : queueName: "default", capacity: 0.7, maximumCapacity: 90.0, 
> currentCapacity: 0.0, state: Q_RUNNING,  
> ======================
> Queue Name : test 
> Queue State : running 
> Scheduling Info : queueName: "test", capacity: 0.2, maximumCapacity: -1.0, 
> currentCapacity: 0.0, state: Q_RUNNING,  
> ======================
> Queue Name : test2 
> Queue State : running 
> Scheduling Info : queueName: "test2", capacity: 0.1, maximumCapacity: 5.0, 
> currentCapacity: 0.0, state: Q_RUNNING,  
> ======================
> here default is configured to have capacity=70% and maximum capacity = 90%

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to