[
https://issues.apache.org/jira/browse/MAPREDUCE-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167767#comment-13167767
]
Hadoop QA commented on MAPREDUCE-3502:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507037/MAPREDUCE-3502.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1422//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1422//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1422//console
This message is automatically generated.
> Review all Service.stop() operations and make sure that they work before a
> service is started
> ---------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3502
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3502
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: mrv2
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: MAPREDUCE-3502.patch, MAPREDUCE-3502.patch
>
> Original Estimate: 24h
> Time Spent: 2.5h
> Remaining Estimate: 21.5h
>
> MAPREDUCE-3431 has shown that some of the key services's shutdown operations
> are not robust against being invoked before the service is started. They need
> to be by
> # not calling other things if the other things are null
> # not being re-entrant (i.e. make synchronized if possible),
> Maybe
> # have a StopService operation that only stops a service if it is live
> # factor out the is-running test from the base service class and make it a
> pre-check for all the child services, so they bail out sooner rather than
> later. This would be the best as it would be the one guaranteed to work
> consistently across all instances, so only one or two would need testing
> my first iteration will skip the sync though it's something to consider.
> Testing: try to create each instance; call stop() straight after
> construction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
