[
https://issues.apache.org/jira/browse/MAPREDUCE-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168132#comment-13168132
]
Vinod Kumar Vavilapalli commented on MAPREDUCE-3398:
----------------------------------------------------
Few comments on the patch.
NodeStatusPBImpl.setKeepAliveApplications(): clears containerStatuses? (!)
I guess we can knock off
YarnConfiguration.RM_DELEGATION_TOKEN_KEEPALIVE_TIME_MS altogether to instead
use the NM-expiry interval itself. This configuration anyways needs to capped
by the expiry interval. We may need it only if we ever want to lessen the
keep-alive, but with the token-expiry usually in the range of 24 hours, we will
hardly ever need to lessen it.
After doing the above, we can drop the documentation changes too.
removal-interval-ms doesn't need to be documented.
NodeStatusUpdaterImpl:
- createKeepAliveApplicationList(): The two loops can be rolled into one, a
single loop iterating over appTokenKeepAliveMap?
DelegationTokenRenewer:
- May I suggesting renaming DelegationTokenRenewer.removeApplication() to
applicationFinished() and removeApplicationInternal() to
removeApplicationFromRenewal()?
> Log Aggregation broken in Secure Mode
> -------------------------------------
>
> Key: MAPREDUCE-3398
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3398
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, nodemanager
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Priority: Critical
> Fix For: 0.23.1
>
> Attachments: MR3398_v1.txt, MR3398_v2.txt, MR3398_v3.txt
>
>
> Log aggregation in secure mode does not work with MAPREDUCE-2977. The
> nodemanager relies on the users credentials to write out logs to HDFS. These
> credentials are currently cancelled once a job completes, before the NM can
> write out the logs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
