[
https://issues.apache.org/jira/browse/MAPREDUCE-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198887#comment-13198887
]
Robert Joseph Evans commented on MAPREDUCE-3711:
------------------------------------------------
Sure I will add more tests, and look at what I can do to make the code between
the different FOCs common. But I think the condition as it was written is
correct, it is confusing and should be changed to {code}(JobType == Reducer ||
numReducers <= 0){code}.
||JobType/hasReducers||Map||Reduce||Legacy(Setup/Cleanup)||
||numReducers > 0|False|True|False/Don't Care|
||numReducers <= 0|True|True|False/Don't Care|
{code}
hasReducers = (numReducers > 0);
JobType == Reduce || !hasReducers
{code}
This works for all cases except {code}JobType == (Setup|Cleanup) &&
!hasReducers{code}. But that is a Don't Care (Because it is legacy). If you
want I could make it exactly {code}JobType == Reduce || (JobType == Map &&
numReducers <= 0){code}
Or we can double invert it
{code}
!(!(JobType == Reduce || !hasReducers))
//And carry the invert through
!(JobType != Reduce && hasReducers)
//But because the Legacy is a don't care JobType != Reduce is equivalent to
JobType == MAP
!(JobType == MAP && hasReducers) // which is what is in the code.
{code}
> AppMaster recovery for Medium to large jobs take long time
> ----------------------------------------------------------
>
> Key: MAPREDUCE-3711
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3711
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Siddharth Seth
> Assignee: Robert Joseph Evans
> Priority: Blocker
> Fix For: 0.23.1
>
> Attachments: MR-3711.txt, MR-3711.txt
>
>
> Reported by [~karams]
> yarn.resourcemanager.am.max-retries=2
> Ran test cases with sort job on 350 scale having 16800 maps and 680 reduces -:
> 1. After 70 secs of Job Sumbission Am is killed using kill -9, around 3900
> maps were completed and 680 reduces were
> scheduled, Second AM got restart. Job got completed in 980 secs. AM took very
> less time to recover.
> 2. After 150 secs of Job Sumbission AM is killed using kill -9, around 90%
> maps were completed and 680 reduces were
> scheduled , Second AM got restart Job got completed in 1000 secs. AM got
> revocer.
> 3. After 150 secs of Job Sumbission AM as killed using kill -9, almost all
> maps were completed and only 680 reduces
> were running, Recovery was too slow, AM was still revocering after 1hr :40
> mis when I killed the run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
