[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201745#comment-13201745
 ] 

Arun C Murthy commented on MAPREDUCE-3809:
------------------------------------------

Looks fine, we could improve it further by ensuring there is no window between 
checking of taskDone.get at the top of while loop and teh sleep, we could check 
taskDone again before the wait, in the sync block to make sure.
                
> Tasks may take upto 3 seconds to exit after completion
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-3809
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3809
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.1, 1.0.0
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Blocker
>         Attachments: MR3809.txt
>
>
> Task.TaskReporter.stopCommunicationThread can end up waiting for a 
> thread.sleep(3000) before stopping the thread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to