[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated MAPREDUCE-3872:
------------------------------------

    Attachment: MAPREDUCE-3872.patch

Refreshing the patch. Looks like MAPREDUCE-3634 fixed a number of the issues I 
had originally seen/fixed in this patch.

The latest version of this patch fixes the obvious concurrency bug in updating 
allNodes. This patch is currently tested by the unit tests, I don't see a way 
to trigger the bad case given it's non-deterministic. However by inspection you 
can see the obvious concurrency bug that exists in the current code.
                
> event handling races in ContainerLauncherImpl and TestContainerLauncher
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3872
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3872
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client, mrv2
>    Affects Versions: 0.23.1
>            Reporter: Patrick Hunt
>         Attachments: MAPREDUCE-3872.patch, MAPREDUCE-3872.patch
>
>
> TestContainerLauncher is failing intermittently for me.
> {noformat}
> junit.framework.AssertionFailedError: Expected: <null> but was: Expected 22 
> but found 21
>       at junit.framework.Assert.fail(Assert.java:47)
>       at junit.framework.Assert.assertTrue(Assert.java:20)
>       at junit.framework.Assert.assertNull(Assert.java:233)
>       at junit.framework.Assert.assertNull(Assert.java:226)
>       at 
> org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncher.testPoolSize(TestContainerLauncher.java:117)
> {noformat}
> Patch momentarily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to