[ https://issues.apache.org/jira/browse/MAPREDUCE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215077#comment-13215077 ]
Hadoop QA commented on MAPREDUCE-3738: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515804/MAPREDUCE-3738.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1917//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1917//console This message is automatically generated. > NM can hang during shutdown if AppLogAggregatorImpl thread dies unexpectedly > ---------------------------------------------------------------------------- > > Key: MAPREDUCE-3738 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3738 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2, nodemanager > Affects Versions: 0.23.1, 0.24.0 > Reporter: Jason Lowe > Assignee: Jason Lowe > Priority: Critical > Attachments: MAPREDUCE-3738.patch, livehistdump.txt > > > If an AppLogAggregator thread dies unexpectedly (e.g.: uncaught exception > like OutOfMemoryError in the case I saw) then this will lead to a hang during > nodemanager shutdown. The NM calls AppLogAggregatorImpl.join() during > shutdown to make sure log aggregation has completed, and that method > internally waits for an atomic boolean to be set by the log aggregation > thread to indicate it has finished. Since the thread was killed off earlier > due to an uncaught exception, the boolean will never be set and the NM hangs > during shutdown repeating something like this every second in the log file: > 2012-01-25 22:20:56,366 INFO > org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl: > Waiting for aggregation to complete for application_1326848182580_2806 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira