[ https://issues.apache.org/jira/browse/MAPREDUCE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221259#comment-13221259 ]
Thomas Graves commented on MAPREDUCE-3954: ------------------------------------------ Mostly looks good. And thanks for updating the docs. A couple minor documentation nits. - can you update the comment Environment Variables section at the top of bin/yarn for the new variables - you might add a header to the table in the ClusterSetup - with Daemon | Environment Variable - You didn't change this so its optional. It might be nice in ClusterSetup to say that you configure it size in MB but you leave off the m. Because when I read that I thought I would set the env var to 1000MB. > Clean up passing HEAPSIZE to yarn and mapred commands. > ------------------------------------------------------ > > Key: MAPREDUCE-3954 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3954 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 0.23.2 > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > Priority: Blocker > Attachments: MR-3954.txt, MR-3954.txt > > > Currently the heap size for all of these is set in yarn-env.sh. > JAVA_HEAP_MAX is set to -Xmx1000m unless YARN_HEAPSIZE is set. If it is set > it will override JAVA_HEAP_MAX. However, we do not always want to have the > RM, NM, and HistoryServer with the exact same heap size. It would be logical > to have inside of yarn and mapred to set JAVA_HEAP_MAX if > YARN_RESOURCEMANAGER_HEAPSIZE, YARN_NODEMANAGER_HEAPSIZE or > HADOOP_JOB_HISTORYSERVER_HEAPSIZE are set respectively. This is a bug > because it is easy to configure the history server to store more entires then > the heap can hold. It is also a performance issue if we do not allow the > history server to cache many entries on a large cluster. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira