[
https://issues.apache.org/jira/browse/MAPREDUCE-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221344#comment-13221344
]
Konstantin Shvachko commented on MAPREDUCE-3837:
------------------------------------------------
I've been reviewing this patch, and have a couple of cosmetic comments below.
I agree with Alejandro. This is not introducing new feature, it is just
enabling already existing feature. There is low risk, since the feature is
enabled in a restricted context, that is restarting failed jobs from scratch
rather than trying to continue from the point they were terminated.
The patch seems to be larger than it actually is, because it is removing the
[troubled] logic responsible for resurrecting the job from its history. Besides
that it is simple. Take a look, Arun.
Cosmetic comments
- Several lines are too long
- See several tabs - should be spaces
- indentation is wrong in couple of places
recoveryManager.addJobForRecovery(JobID.forName(fileName));
shouldRecover = true; // enable actual recovery if num-files > 1
- Add spaces after commas in method calls and parameters
Otherwise it looks good.
> Hadoop 22 Job tracker is not able to recover job in case of crash and after
> that no user can submit job.
> --------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3837
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3837
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Fix For: 0.24.0, 0.22.1, 0.23.2
>
> Attachments: PATCH-HADOOP-1-MAPREDUCE-3837-1.patch,
> PATCH-HADOOP-1-MAPREDUCE-3837.patch, PATCH-MAPREDUCE-3837.patch,
> PATCH-TRUNK-MAPREDUCE-3837.patch
>
>
> If job tracker is crashed while running , and there were some jobs are
> running , so if job tracker's property mapreduce.jobtracker.restart.recover
> is true then it should recover the job.
> However the current behavior is as follows
> jobtracker try to restore the jobs but it can not . And after that jobtracker
> closes its handle to hdfs and nobody else can submit job.
> Thanks,
> Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
