[ https://issues.apache.org/jira/browse/MAPREDUCE-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222538#comment-13222538 ]
Hadoop QA commented on MAPREDUCE-3954: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517108/MAPREDUCE-3954-20120305.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.mapred.TestJobClientGetJob org.apache.hadoop.mapred.TestMRWithDistributedCache org.apache.hadoop.mapred.TestLocalModeWithNewApis +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2000//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2000//console This message is automatically generated. > Clean up passing HEAPSIZE to yarn and mapred commands. > ------------------------------------------------------ > > Key: MAPREDUCE-3954 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3954 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 0.23.2 > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > Priority: Blocker > Fix For: 0.23.2 > > Attachments: MAPREDUCE-3954-20120305.txt, MR-3954.txt, MR-3954.txt, > MR-3954.txt > > > Currently the heap size for all of these is set in yarn-env.sh. > JAVA_HEAP_MAX is set to -Xmx1000m unless YARN_HEAPSIZE is set. If it is set > it will override JAVA_HEAP_MAX. However, we do not always want to have the > RM, NM, and HistoryServer with the exact same heap size. It would be logical > to have inside of yarn and mapred to set JAVA_HEAP_MAX if > YARN_RESOURCEMANAGER_HEAPSIZE, YARN_NODEMANAGER_HEAPSIZE or > HADOOP_JOB_HISTORYSERVER_HEAPSIZE are set respectively. This is a bug > because it is easy to configure the history server to store more entires then > the heap can hold. It is also a performance issue if we do not allow the > history server to cache many entries on a large cluster. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira