[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223426#comment-13223426
 ] 

Alejandro Abdelnur commented on MAPREDUCE-2835:
-----------------------------------------------

Initializing a static var with a 'loaded' configuration value at class loading 
time seems too wrong. If we need to do something like this I would add an 
'static init()' method to do this initialization and call this method in the 
lifecycle of the corresponding services (JT/TT).

If the code that checks those limits is invoked on the client side when a 
client is querying counters, this may break the client app if this limit is not 
set in the client mapred-site.xml. This seems wrong as this is a server config 
property.

Also, would this check impact the job tasks? If so the counter initialization 
should be done in the task bootstrap code.

+1 as this is enables custom limits but we should follow up with a proper fix 
(MAPREDUCE-3936)
                
> Make per-job counter limits configurable
> ----------------------------------------
>
>                 Key: MAPREDUCE-2835
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2835
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.20.204.0
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-2835.patch, MAPREDUCE-2835.patch
>
>
> The per-job counter limits introduced in MAPREDUCE-1943 are fixed, except for 
> the total number allowed per job (mapreduce.job.counters.limit). It would be 
> useful to make them all configurable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to