[
https://issues.apache.org/jira/browse/MAPREDUCE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255615#comment-13255615
]
Robert Joseph Evans commented on MAPREDUCE-3972:
------------------------------------------------
Will update the conf usage APIs.
bq. Isn't it better to put state = HistoryInfoState.DELETED as a last statement
in the HistoryFileInfo#delete method? or any reasons?
I moved it up at Sid's request. He had some concern about synchronization.
Because the method is synchronized the only case where it makes a difference is
when the delete fails with an IOException while trying to delete one of the
files (which the old code handled very badly). Having the delete at the top
will make it so that we do not retry the delete on errors until that entry is
removed from the job list cache. Having it at the bottom means that on a
failure the state could be left as IN_DONE, but have one of the files gone. I
don't think either will cause any real problems so I would prefer to just leave
it the way that it is.
> Locking and exception issues in JobHistory Server.
> --------------------------------------------------
>
> Key: MAPREDUCE-3972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3972
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2
> Affects Versions: 0.23.2
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: MR-3972.txt, MR-3972.txt, MR-3972.txt, MR-3972.txt,
> MR-3972.txt
>
>
> The JobHistory server's locking is inconsistent and wrong in some cases.
> This is not super critical because the issues would only show up if a job is
> being cleaned up or moved from intermediate done to done, at the same time it
> is being parsed into a CompletedJob. However the locking is slowing down the
> server in some cases, and is a ticking time bomb that needs to be addressed.
> As part of this too we need to be sure that the Cleaner and Intermediate to
> Done migration threads handle exceptions properly. Now it appears that the
> exception is logged, and the thread just shuts down. This means that the
> history server could still be up and running for weeks and never remove old
> jobs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
