[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257627#comment-13257627
 ] 

Robert Joseph Evans commented on MAPREDUCE-4157:
------------------------------------------------

I am not an expert on all of the transitions in the RM so more reviews would 
probably be good. The code looks good to me and the tests look good to me.  I 
looked at the transition diagrams and the changes made look fine. +1
                
> ResourceManager should not kill apps that are well behaved
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-4157
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4157
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 2.0.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4157.patch
>
>
> Currently when the ApplicationMaster unregisters with the ResourceManager, 
> the RM kills (via the NMs) all the active containers for an application.  
> This introduces a race where the AM may be trying to clean up and may not 
> finish before it is killed.  The RM should give the AM a chance to exit 
> cleanly on its own rather than always race with a pending kill on shutdown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to