[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259457#comment-13259457
 ] 

Harsh J commented on MAPREDUCE-4169:
------------------------------------

Patch looks good to me (Did you verify the results manually too? Looks about 
right but I've not verified it manually yet). +1 on this - just one nit: Can 
you also add in a very short 'purpose' comment for each place you've done the 
sorting at? Having tests seems difficult for these particular classes so we can 
at least do with comments to help prevent removal/regress.
                
> Container Logs appear in unsorted order
> ---------------------------------------
>
>                 Key: MAPREDUCE-4169
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4169
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.3, 2.0.0
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>            Priority: Minor
>         Attachments: MAPREDUCE-4169.patch
>
>
> container logs (stdout, stderr, syslog) in the nodemanager ui and jobhistory 
> ui appear in unsorted order where the order displayed is based on what file 
> was created first. This jira will have the results be displayed in a 
> consistent order.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to