[
https://issues.apache.org/jira/browse/MAPREDUCE-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261843#comment-13261843
]
Bikas Saha commented on MAPREDUCE-3921:
---------------------------------------
Here is how I read TaskAttemptCompletedEventTransition in JobImpl
Task T has a new attempt completion event T2.
At this point T1 is a successful attempt that has been recorded in
successAttemptCompletionEventNoMap. So it is still a valid successful event.
T is removed from successAttemptCompletionEventNoMap and its T1
taskAttemptCompletionEvents entry is marked obsolete.
Now T2 status is checked and if successful, T is added to
successAttemptCompletionEventNoMap.
This means while retry T2 was running, T was considered successful because it
was in successAttemptCompletionEventNoMap.
1) So if we want to *not* leave a task as successful when being retried, then T
should already have been removed from successAttemptCompletionEventNoMap and T1
marked obsolete. Removing T after completion of T2 is not correct.
2) However, if we want T to remain successful until we have another successful
attempt, then it should be removed from successAttemptCompletionEventNoMap only
when T2 is successful. But currently we remove T from
successAttemptCompletionEventNoMap regardless of T2's status.
> MR AM should act on the nodes liveliness information when nodes go
> up/down/unhealthy
> ------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3921
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3921
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mr-am, mrv2
> Affects Versions: 0.23.0
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Bikas Saha
> Fix For: 0.23.2
>
> Attachments: MAPREDUCE-3921-1.patch, MAPREDUCE-3921-3.patch,
> MAPREDUCE-3921-4.patch, MAPREDUCE-3921-5.patch, MAPREDUCE-3921-6.patch,
> MAPREDUCE-3921-7.patch, MAPREDUCE-3921-branch-0.23.patch,
> MAPREDUCE-3921-branch-0.23.patch, MAPREDUCE-3921-branch-0.23.patch,
> MAPREDUCE-3921.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
