[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261951#comment-13261951
 ] 

Jonathan Eagles commented on MAPREDUCE-4194:
--------------------------------------------

Thanks for the review, Bobby. I have changed the test to put temp files in 
target/<testclass>/* and that dir is now cleaned up after the test class is 
run. Also I have changed the return type to an unmodifiableList, keeping the 
CopyOnWriteArrayList backing store. This prevents the 
ConcurrentModificationException while protecting the internal data structure 
from being accidentally being changed. 

Note the test is in a new file.
                
> ConcurrentModificationError in DirectoryCollection
> --------------------------------------------------
>
>                 Key: MAPREDUCE-4194
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4194
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.3, 2.0.0
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: MAPREDUCE-4194.patch, MAPREDUCE-4194.patch
>
>
> As found as part of work on MAPREDUCE-4169, it is possible for a 
> ConcurrentModificationException to be thrown upon disk failure. 
> DirectoryCollection hands out its internal list structure that is accessed 
> across multiple threads. Upon disk failure its internal list is modified, 
> invalidating all current iterators to that structure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to