[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263509#comment-13263509
 ] 

Radim Kolar commented on MAPREDUCE-4204:
----------------------------------------

ResourceCalculatorProcessTree should be merged with existing 
ResourceCalculatorPlugin infractructure.

It means:

1. remove ResourceCalculatorProcessTree getResourceCalculatorProcessTree and 
move it to ResourceCalculatorPlugin as abstract member method.

2. LinuxResourceCalculatorPlugin will return procfsBasedProcessTree

3. method isAvailable() should not be needed, it is checked at lot of places. 
Removing it will simplify code. Unsupported operation systems get null from 
getResourceCalculatorPlugin and no plugin means no 
ResourceCalculatorProcessTree as well.

4. 
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMemoryMonitorImpl
 must be modified to work with ResourceCalculatorPlugin
                
> Refactor ProcfsBasedProcessTree to make the resource collection object 
> pluggable
> --------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4204
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4204
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: MAPREDUCE-4204.patch
>
>
> Making it a pluggable interface will allow replacing the procfs based 
> implementation with ones for other platforms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to