[ https://issues.apache.org/jira/browse/MAPREDUCE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265179#comment-13265179 ]
Alejandro Abdelnur commented on MAPREDUCE-3871: ----------------------------------------------- +1. looks good, a small nit, I'd check for 'link != null' before calling the symlinking method, else give the impression the you are always symlinking. > Allow symlinking in LocalJobRunner DistributedCache > --------------------------------------------------- > > Key: MAPREDUCE-3871 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3871 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: distributed-cache > Reporter: Tom White > Assignee: Tom White > Attachments: MAPREDUCE-3871.patch, MAPREDUCE-3871.patch > > > Currently the LocalJobRunner doesn't create symlinks for files in the > DistributedCache. It is safe to create symlinks if files of the same name > don't exist. LocalJobRunner should also delete the symlinks when the job has > completed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira