[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266686#comment-13266686
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4219:
-----------------------------------------------

+1, patched, built & tested native stuff.

Also, it would be great if you test it a deployed cluster before we commit it?

2 NITs:

* function name, IMO, *resolve_config_path* would be a more appropriate name.
* add a comment where *HADOOP_CONF* is used in *main.c* that the value comes 
from the POM property *container-executor.conf.dir*


                
> make default container-executor.conf.dir be a path relative to the 
> container-executor binary
> --------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4219
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4219
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.23.1
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8332.patch.txt
>
>
> Currently, container-executor binary has an absolute pathname of its 
> configuration file baked in. This prevents an easy relocation of the 
> configuration files when dealing with multiple Hadoop installs on the same 
> node. It would be nice to at least allow for a relative path resolution 
> starting from the location of the container-executor binary itself. Something 
> like
> {noformat}
> ../etc/hadoop/
> {noformat}
> Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to