[
https://issues.apache.org/jira/browse/MAPREDUCE-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291027#comment-13291027
]
Daryn Sharp commented on MAPREDUCE-4321:
----------------------------------------
+1 Looks good! One suggestion to maybe consider, would it in general help to
create a {{Path#toFile()}} and {{Path(File)}} ctor? I had consider the
additional ctor change on HADOOP-8139 and I believe Doug liked the idea.
> DefaultTaskController fails to launch tasks on Windows
> ------------------------------------------------------
>
> Key: MAPREDUCE-4321
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4321
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: MAPREDUCE-4321-branch-1-win.patch
>
>
> DefaultTaskController#launchTask tries to run the child JVM task with the
> following command line:
> {code}cmd.exe /c /c:/some/path.../taskjvm.cmd{code}
> And this fails because the given path is prefixed with a forward slash. This
> also causes a number of tests to fail:
> org.apache.hadoop.conf.TestNoDefaultsJobConf
> org.apache.hadoop.fs.TestCopyFiles
> org.apache.hadoop.mapred.TestBadRecords
> org.apache.hadoop.mapred.TestClusterMRNotification
> org.apache.hadoop.mapred.TestCompressedEmptyMapOutputs
> org.apache.hadoop.mapred.TestControlledMapReduceJob
> org.apache.hadoop.mapred.TestCustomOutputCommitter
> org.apache.hadoop.mapred.TestEmptyJob
> org.apache.hadoop.mapred.TestFileOutputFormat
> org.apache.hadoop.mapred.TestIsolationRunner
> org.apache.hadoop.mapred.TestJavaSerialization
> org.apache.hadoop.mapred.TestJobCleanup
> org.apache.hadoop.mapred.TestJobCounters
> org.apache.hadoop.mapred.TestJobHistoryServer
> org.apache.hadoop.mapred.TestJobInProgressListener
> org.apache.hadoop.mapred.TestJobKillAndFail
> org.apache.hadoop.mapred.TestJobName
> ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
