[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397742#comment-13397742
 ] 

Robert Joseph Evans commented on MAPREDUCE-4351:
------------------------------------------------

I have been looking a little more closely at the patch.  I am a bit confused as 
to why the creation of the ContainersMonitor was moved from 
ContainerManagerImpl to NodeManager.  The NodeManager does not appear to have 
any need for it.

to Answer your question {quote}One point I would like feedback on: 
ContainerManagerImpl's getContainersMonitor() is only used in NodeManager's 
init() as part of the call to createWebServer() — but with this patch, the 
ContainersMonitor is now created locally and passed to the ContainerManager in 
NodeManager's init(). Does it make sense to remove this function?{quote}  I 
don't really see a need to change it at this point, especially if we push the 
creation of the ContainersMonitor back into the ContainerManagerImpl.

I would also like to see some more documentation about how a ContainersMonitor 
is supposed to behave.  The only API in there is setup.  It would be nice to be 
able to document what events a ContaiersMonitor is expected to handle 
(START_MONITORING_CONTAINER, STOP_MONITORING_CONTAINER) and how it may 
optionally stop a misbehaving container ContainerKillEvent.
                
> Make ContainersMonitor pluggable
> --------------------------------
>
>                 Key: MAPREDUCE-4351
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4351
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, nodemanager
>            Reporter: Andrew Ferguson
>            Assignee: Andrew Ferguson
>         Attachments: MAPREDUCE-4351-v1.patch, MAPREDUCE-4351-v2.patch, 
> MAPREDUCE-4351-v3.patch, MAPREDUCE-4351-v4.patch, MAPREDUCE-4351-v4.patch
>
>
> Make the existing ContainersManager pluggable, just as the ContainerExecutor 
> is currently. This will allow us to add container resource enforcement using 
> other techniques (such as cgroups) in an extensible fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to