[
https://issues.apache.org/jira/browse/MAPREDUCE-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399592#comment-13399592
]
Jason Lowe commented on MAPREDUCE-4361:
---------------------------------------
test-patch doesn't know how to test patches that aren't based on trunk.
Manually ran test-patch on branch-0.23 and got these results:
{panel}
-1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 18 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
{panel}
The javadoc warnings are unrelated to the patch (mostly involving issues in
Rumen and Hadoop Extras).
> Fix detailed metrics for protobuf-based RPC on 0.23
> ---------------------------------------------------
>
> Key: MAPREDUCE-4361
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4361
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: MAPREDUCE-4361.patch
>
>
> RPC detailed metrics for any protobuf-based RPC ports are always zero.
> ProtoOverHadoopRpcEngine needs the same detailed metric logic as in
> WritableRpcEngine. This is effectively the same change as in HADOOP-8085
> except tailored for branch-0.23 which didn't take the full protobuf branch
> changes that went into branch-2 and trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
