[ https://issues.apache.org/jira/browse/MAPREDUCE-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401462#comment-13401462 ]
Todd Lipcon commented on MAPREDUCE-4359: ---------------------------------------- Patch looks good to me. If this is in trunk we should do a trunk patch at the same time, though. > Potential deadlock in Counters > ------------------------------ > > Key: MAPREDUCE-4359 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4359 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 1.0.3 > Reporter: Todd Lipcon > Assignee: Tom White > Attachments: 1_jcarder_result_0.dot.png, MAPREDUCE-4359.patch > > > jcarder identified this deadlock in branch-1 (though it may also be present > in trunk): > - Counters.size() is synchronized and locks Counters before Group > - Counters.Group.getCounterForName() is synchronized and calls through to > Counters.size() > This creates a potential cycle which could cause a deadlock (though probably > quite rare in practice) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira