[
https://issues.apache.org/jira/browse/MAPREDUCE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402489#comment-13402489
]
Bikas Saha commented on MAPREDUCE-4322:
---------------------------------------
Thats exactly what I am saying too :) The test is trying to cover both cases,
but the result is kind of implicit right now because we know both paths are
being covered. However, in the test itself by checking for only sb.toString()
we are not making that explicit. There is nothing to hardcode. Unless I am
reading the test code incorrectly, we have already defined List<string> setup
and List<string> cmd. In the exception message, along with checking for
sb.toString(), we could also check for setup[0] and cmd[0]. That way its
explicit that 2 different paths are being covered.
> Fix command-line length abort issues on Windows
> -----------------------------------------------
>
> Key: MAPREDUCE-4322
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4322
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Environment: Windows, downstream applications with long aggregate
> classpaths
> Reporter: John Gordon
> Assignee: Ivan Mitic
> Attachments: MAPREDUCE-4322-branch-1-win(2).patch,
> MAPREDUCE-4322-branch-1-win(3).patch, MAPREDUCE-4322-branch-1-win(4).patch,
> MAPREDUCE-4322-branch-1-win.patch
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> When a task is started on the tasktracker, it creates a small batch file to
> invoke java and runs that batch. Within the batch file, the invocation of
> Java currently has -classpath ${CLASSPATH} inline to the command. That line
> often exceeds 8000 characters. This is ok for most linux distributions
> because the line limit env variable is often set much higher than this.
> However, for Windows this cause cmd to abort execution. This surfaces in
> Hadoop as an unknown failure mode for the task.
> I think the easiest and most natural way to fix this is to push the
> -classpath option into a config file to take the longest variable part of the
> line and put it somewhere that scales better.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
