[
https://issues.apache.org/jira/browse/MAPREDUCE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411119#comment-13411119
]
Konstantin Shvachko edited comment on MAPREDUCE-4403 at 7/11/12 6:33 AM:
-------------------------------------------------------------------------
The code looks good. Two things:
# {{TEST_DIR = "/tmp";}}
It is better if we don't use /tmp in the tests, as /tmp is not being cleaned up
by the build clean target. I suggest to replace it with {{TEST_DIR =
"build/tmp";}}
# You need to wrap most of the code into {{try finally}}, where {{finally}} and
call {{mr.shutdown()}} in the {{finally}} section. You are starting and
stopping JobTracker in the test. When it fails the mini-cluster will not
shutdown, which may affect subsequent tests.
This is not related to your particular patch, because it was introduced in
other test cases, and I do not propose to change the old code. I am just
advocating to set a better example with the new code.
was (Author: shv):
The code looks good. Two things:
# {{TEST_DIR = "/tmp";}}
It is better if we don't use /tmp in the tests, as /tmp is not being cleaned up
by the build clean target. I suggest to replace it with {{TEST_DIR =
"build/tmp";}}
# You need to wrap most of the code into {{try finally}}, where {{finally}} and
call {{mr.shutdown()}} in the {{finally}} section. You are starting and
stopping JobTracker in the test. When it fails the mini-cluster will not
shutdown, which may affect subsequent tests.
> Adding test case for resubmission of jobs in TestRecoveryManager
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-4403
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4403
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.22.0
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4403-22.patch
>
>
> In Hadoop 22 Test recovery Manager does not have resubmission test case which
> checks after the resubmission jobs get succeeded.
> There is some refactoring is also needed.
> Thanks,
> Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
