[ https://issues.apache.org/jira/browse/MAPREDUCE-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413979#comment-13413979 ]
Robert Joseph Evans commented on MAPREDUCE-4395: ------------------------------------------------ Looking at the patch it looks OK to me. I looked and the only other thing that uses this API is streaming, when it is setting up a JobConf, so I am OK with it blowing up when the URI is not valid. My only comment is that I would like the Javadocs for this method updated to explain what it does and also indicate what happens in the failure case. because well {code} /** * * @param str */ {code} is completely useless. > Possible NPE at ClientDistributedCacheManager#determineTimestamps > ----------------------------------------------------------------- > > Key: MAPREDUCE-4395 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4395 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: distributed-cache, job submission, mrv2 > Affects Versions: 2.0.0-alpha, trunk > Reporter: Bhallamudi Venkata Siva Kamesh > Assignee: Bhallamudi Venkata Siva Kamesh > Priority: Critical > Attachments: MAPREDUCE-4395.patch > > > {code:title=ClientDistributedCacheManager#determineTimestamps|borderStyle=solid} > URI[] tfiles = DistributedCache.getCacheFiles(job); > {code} > It may be possible that tfiles array contains *null* as it's entry, and > subsequently leads to NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira