[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414145#comment-13414145
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4422:
-----------------------------------------------

Ahmed, one NIT I see: The default value should be a String[], doing the 
"....".split() in teh constant definition. Then when using it as default value 
there is not split() call over and over.
                
> YARN_APPLICATION_CLASSPATH needs a documented default value in 
> YarnConfiguration
> --------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4422
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.0.0-alpha
>            Reporter: Arun C Murthy
>            Assignee: Ahmed Radwan
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, 
> MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to