[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417185#comment-13417185
 ] 

Harsh J commented on MAPREDUCE-4431:
------------------------------------

Thanks Devaraj. Couple of points:

* In case of a job -kill on killed, failed or succeeded jobs, given your patch, 
we'll get a very ambiguous: "Could not kill the Job since the Job State is 
{KILLED,FAILED,SUCCEEDED}.".
** Perhaps we can instead check for state better and say things in each case 
thats more apt/intelligible.
*** "Could not kill the job <job ID>, as it has already succeeded."
*** "Could not mark the job <job ID> as killed, as it has already failed."
*** "The job <job ID> has already been killed."
* Can we have a test for this? That is, if we're trying to prevent a double 
killJob() calls to the AM/cluster.
                
> killing already completed job gives ambiguous message as "Killed job <job id>"
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Nishan Shetty
>            Assignee: Devaraj K
>            Priority: Minor
>         Attachments: MAPREDUCE-4431.patch
>
>
> If we try to kill the already completed job by the following command it gives 
> ambiguous message as "Killed job <job id>"
> ./mapred job -kill <already completed job id>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to