[
https://issues.apache.org/jira/browse/MAPREDUCE-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419701#comment-13419701
]
Patrick Wendell commented on MAPREDUCE-4452:
--------------------------------------------
What really confuses me here is that you've added _new locks_ for
(queueMaxApps, userMaxApps, queueWeights, etc) in this patch rather than
synchronizing them under the existing lock that's held when they are set.
Really this doesn't ensure that they won't be concurrently read/modified any
more than before, but it looks like findbugs just check's that variables are
consistently read or modified under _some lock_ rather than under the same
lock. That's odd to me.
> Several Findbugs issues with new FairScheduler in YARN
> ------------------------------------------------------
>
> Key: MAPREDUCE-4452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 2.1.0-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: MAPREDUCE-4452-v1.patch, MAPREDUCE-4452-v2.patch,
> MAPREDUCE-4452.patch
>
>
> The good feature of FairScheduler is added recently to YARN. As recently
> PreCommit test from MAPREDUCE-4309, there are several bugs found by Findbugs
> related to FairScheduler:
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerEventLog.shutdown()
> might ignore java.lang.Exception
> Inconsistent synchronization of
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerEventLog.logDisabled;
> locked 50% of time
> Inconsistent synchronization of
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.queueMaxAppsDefault;
> locked 50% of time
> Inconsistent synchronization of
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.userMaxAppsDefault;
> locked 50% of time
> The details are
> in:https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2612//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html#DE_MIGHT_IGNORE
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
