[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423294#comment-13423294
 ] 

Andrew Ferguson commented on MAPREDUCE-4334:
--------------------------------------------

Hi,

bq. Why the ResourceEnforcer is bubble up all the way to the NodeManager 
instead just being instantiated & configured in the ContainerLauncher where it 
seems the use of before() & after() and then passed to the ContainerExecutor as 
a parameter in the launchContainer() method?

the reason is because I was trying to pattern-match how the ContainerExecutor 
works, and the ContainerExecutor is instantiated by the NodeManager. If you 
think it makes more sense to break with the pattern and keep the 
ResourceEnforcer localized to the ContainersLauncher, then I certainly do that.

thanks! I will incorporate your other comments into the patch.

Andrew
                
> Add support for CPU isolation/monitoring of containers
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4334
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4334
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>            Reporter: Arun C Murthy
>            Assignee: Andrew Ferguson
>         Attachments: MAPREDUCE-4334-executor-v1.patch, 
> MAPREDUCE-4334-executor-v2.patch, MAPREDUCE-4334-pre1.patch, 
> MAPREDUCE-4334-pre2-with_cpu.patch, MAPREDUCE-4334-pre2.patch, 
> MAPREDUCE-4334-pre3-with_cpu.patch, MAPREDUCE-4334-pre3.patch, 
> MAPREDUCE-4334-v1.patch, MAPREDUCE-4334-v2.patch
>
>
> Once we get in MAPREDUCE-4327, it will be important to actually enforce 
> limits on CPU consumption of containers. 
> Several options spring to mind:
> # taskset (RHEL5+)
> # cgroups (RHEL6+)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to