[
https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425831#comment-13425831
]
Radim Kolar commented on MAPREDUCE-4275:
----------------------------------------
static isAvailable() is worst possible design, because 1. its static and 2. its
heavyweight compared to not null pointer check. Best design would be to have
one factory per operation system supported which will create different OS
specific objects - currently there are two: ResourceCalculatorProcessTree and
ResourceCalculatorPlugin.
ContainersMonitorImpl is using both ResourceCalculatorProcessTree and
ResourceCalculatorProcessTree.
these space issues are caused by editor killing trailing whitespace, which is
good thing. Probably --ignore-whitespace in patch will strip it.
But because i am really in hurry and this issue takes MONTHS to resolve for no
apparent reason, i will code whatever design you want. If you want static
isAvailable(), i will deliver it. Just state clearly what you want. I will
throw out this code after few months, it will be replaced by pluggable
resources, which are way better design.
> Plugable process tree
> ---------------------
>
> Key: MAPREDUCE-4275
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 3.0.0
> Environment: FreeBSD 64 bit
> Reporter: Radim Kolar
> Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt,
> plugable-pstree.txt
>
>
> Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
