[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429341#comment-13429341
 ] 

Hadoop QA commented on MAPREDUCE-4518:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12539254/MR-4518_branch1.patch
  against trunk revision .

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2712//console

This message is automatically generated.
                
> FairScheduler: PoolSchedulable#updateDemand() - potential redundant 
> aggregation
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4518
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4518
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: MR-4518_branch1.patch
>
>
> In FS, PoolSchedulable#updateDemand() limits the demand to maxTasks only 
> after iterating though all the pools and computing the final demand. 
> By checking if the demand has reached maxTasks in every iteration, we can 
> avoid redundant work, at the expense of one condition check every iteration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to