[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siddharth Seth updated MAPREDUCE-4455:
--------------------------------------

       Fix Version/s:     (was: trunk)
    Target Version/s: 2.2.0-alpha
              Status: Open  (was: Patch Available)

Mayank, these transitions don't seem to be valid. I got this wrong while 
talking to you about this earlier... sorry about that.

The unit test is broken in this case. The InlineDispatcher, which is used for 
this test and others, behaves differently from the regular dispatcher. It 
handles all events inline, as against handling one event to completion before 
processing the next one.
For this test - the App should have transitioned to the KILLED state, before 
the ATTEMPT_KILLED event came in.
The DrainDispatcher seems like a much better option for unit tests.
                
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4455
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, resourcemanager
>            Reporter: Jason Lowe
>            Assignee: Mayank Bansal
>            Priority: Minor
>         Attachments: MAPREDUCE-4455-trunk-v1.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception 
> but the test doesn't catch the error since the final app state is still 
> killed.  Killed for the wrong reason, but the final state is the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to