[ https://issues.apache.org/jira/browse/MAPREDUCE-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436167#comment-13436167 ]
Thomas Graves commented on MAPREDUCE-4296: ------------------------------------------ Mostly looks good. couple minor things: * we should add new configs to the release notes. * YarnConfiguration - the comment is wrong (+ /** Whether to enable log aggregation */) - should be to enable log aggregation deletion service. * I'm on the wall about the 30 minute check. In one way its nice so users don't shoot themselves but at the same time it makes it harder to test and is less flexible. I think in the minimum we should document that we have the 30 minute config, otherwise perhaps just remove the check and add a comment that you shouldn't set it to low. > remove old aggregated logs > -------------------------- > > Key: MAPREDUCE-4296 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4296 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 0.23.3 > Reporter: Thomas Graves > Assignee: Robert Joseph Evans > Attachments: MR-4296.txt, MR-4296.txt, MR-4296.txt > > > Currently the aggregated user logs under NM_REMOTE_APP_LOG_DIR are never > removed. We should have mechanism to remove them after certain period. > It might make sense for job history server to remove them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira