[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468817#comment-13468817
 ] 

Suresh Srinivas commented on MAPREDUCE-4657:
--------------------------------------------

bq. Thats because I dont want to suppress the log. This would indicate running 
with an incompatible version of winutils
I understand that. Why LOG.info and not LOG.warn(). The logs seem like they 
should be warning.

bq. There is no log when sysInfo is null. Can you apply the patch to the code 
and check again?
I am not sure I understand your comment. Prior to your patch when sysInfo is 
null, a null pointer exception happened indicating an error. Now there is no 
log? However after closely looking at the code, the method used for getting 
sysInfo print LOG.error(). So it should be fine.

                
> WindowsResourceCalculatorPlugin has NPE
> ---------------------------------------
>
>                 Key: MAPREDUCE-4657
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4657
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>            Priority: Minor
>         Attachments: MAPREDUCE-4657.branch-1-win.1.patch
>
>
> When Shell command execution is interrupted then 
> WindowsResourceCalculatorPlugin has NPE.
> code}
> 2012-08-31 13:01:00,140 ERROR [Thread-771] 
> util.WindowsResourceCalculatorPlugin(69): java.io.IOException: 
> java.lang.InterruptedException^M
>         at org.apache.hadoop.util.Shell.runCommand(Shell.java:424)^M
>         at org.apache.hadoop.util.Shell.run(Shell.java:336)^M
>         at 
> org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:540)^M
>         at 
> org.apache.hadoop.util.WindowsResourceCalculatorPlugin.getSystemInfoInfoFromShell(WindowsResourceCalculatorPlugin.java:66)^M
>         at 
> org.apache.hadoop.util.WindowsResourceCalculatorPlugin.refreshIfNeeded(WindowsResourceCalculatorPlugin.java:81)^M
>         at 
> org.apache.hadoop.util.WindowsResourceCalculatorPlugin.getAvailableVirtualMemorySize(WindowsResourceCalculatorPlugin.java:126)^M
>         at 
> org.apache.hadoop.mapred.TaskTracker.getAvailableVirtualMemoryOnTT(TaskTracker.java:1933)^M
>         at 
> org.apache.hadoop.mapred.TaskTracker.transmitHeartBeat(TaskTracker.java:1834)^M
>         at 
> org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1664)^M
>         at org.apache.hadoop.mapred.TaskTracker.run(TaskTracker.java:2516)^M
>         at 
> org.apache.hadoop.mapred.MiniMRCluster$TaskTrackerRunner.run(MiniMRCluster.java:217)^M
>         at java.lang.Thread.run(Thread.java:662)^M
> ^M
> 2012-08-31 13:01:00,140 ERROR [Thread-771] mapred.TaskTracker(1766): Caught 
> exception: java.lang.NullPointerException^M
>         at 
> org.apache.hadoop.util.WindowsResourceCalculatorPlugin.refreshIfNeeded(WindowsResourceCalculatorPlugin.java:83)^M
>         at 
> org.apache.hadoop.util.WindowsResourceCalculatorPlugin.getAvailableVirtualMemorySize(WindowsResourceCalculatorPlugin.java:126)^M
>         at 
> org.apache.hadoop.mapred.TaskTracker.getAvailableVirtualMemoryOnTT(TaskTracker.java:1933)^M
>         at 
> org.apache.hadoop.mapred.TaskTracker.transmitHeartBeat(TaskTracker.java:1834)^M
>         at 
> org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1664)^M
>         at org.apache.hadoop.mapred.TaskTracker.run(TaskTracker.java:2516)^M
>         at 
> org.apache.hadoop.mapred.MiniMRCluster$TaskTrackerRunner.run(MiniMRCluster.java:217)^M
>         at java.lang.Thread.run(Thread.java:662)^M
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to