[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471934#comment-13471934
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4643:
-----------------------------------------------

oh well. looks good, one small NIT though

{code}
+    return result.getTimeInMillis() - 
+        result.getTimeInMillis() % HistoryCleaner.ONE_DAY_IN_MS;
{code}

Assign getTimeInMillis() to a local var and then use that for the expression 
above.


                
> Make job-history cleanup-period configurable
> --------------------------------------------
>
>                 Key: MAPREDUCE-4643
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4643
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-4643-branch1.patch, 
> MAPREDUCE-4643-branch1.patch, MAPREDUCE-4643.patch
>
>
> Job history cleanup should be made configurable. Currently, it is set to 1 
> month by default. The DEBUG_MODE (to be removed, see MAPREDUCE-4629) sets it 
> to 20 minutes, but it should be configurable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to