[ https://issues.apache.org/jira/browse/MAPREDUCE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495427#comment-13495427 ]
Robert Joseph Evans commented on MAPREDUCE-4425: ------------------------------------------------ The patch looks fine to me. When a task fails or is killed retroactively we remove it from inProgess and add it to finished. Also when a task succeeds after already succeeding we add it to finished and remove it from inProgess. +1 I'll check it in. > Speculation + Fetch failures can lead to a hung job > --------------------------------------------------- > > Key: MAPREDUCE-4425 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4425 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 0.23.1 > Reporter: Siddharth Seth > Assignee: Jason Lowe > Priority: Critical > Attachments: MAPREDUCE-4425.patch, MAPREDUCE-4425.patch > > > After a task goes to SUCCEEDED, FAILED/KILLED attempts are ignored. > 1. attemp1 starts > 2. speculative attempt starts > 3. attempt 1 completes - Task moves to SUCCEEDED state > 4. speculative attempt is KILLED > 5. T_ATTEMPT_KILLED is ignored. > 6. attemp1 1 fails with TOO_MANY_FETCH_FAILURES > The job will effectively hang, since a new task attempt isn't started. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira