[ https://issues.apache.org/jira/browse/MAPREDUCE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503917#comment-13503917 ]
Robert Joseph Evans commented on MAPREDUCE-4764: ------------------------------------------------ The changes look good to me +1. > repair test org.apache.hadoop.mapreduce.security.TestBinaryTokenFile > -------------------------------------------------------------------- > > Key: MAPREDUCE-4764 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4764 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: Ivan A. Veselovsky > Attachments: MAPREDUCE-4764.patch, MAPREDUCE-4764-trunk.patch > > > the test is @Ignore-ed, and fails being enabled. > Suggested to repair it to fill the coverage gap. > Problems fixed in the test: > (1) MRConfig.FRAMEWORK_NAME and YarnConfiguration.RM_PRINCIPAL properties > must be correctly set in the configuration to correctly enable the security > in the way this test implies. > (2) The property MRJobConfig.MAPREDUCE_JOB_CREDENTIALS_BINARY now is not > passed into the Job configuration -- it is intentionally deleted from there. > So, we pass the binary file name in another dedicated property. > (3) The test was using deprecated cluster classes. All them are updated to > the modern analogs. > (4) The delegation token found in the job context is now correctly compared > to the one deserialized from the binary file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira