[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mostafa Elhemali updated MAPREDUCE-4840:
----------------------------------------

    Attachment: MAPREDUCE-4840.patch

Patch attached. Disclaimer: the code compiles fine, but I didn't fully test it 
since I wrote this on a Windows box and trunk isn't really good with Windows 
these days.
                
> Delete dead code and deprecate public API related to skipping bad records
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4840
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4840
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: trunk
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: MAPREDUCE-4840.patch
>
>
> It looks like the decision was made in MAPREDUCE-1932 to remove support for 
> skipping bad records rather than fix it (it doesn't work right now in trunk). 
> If that's the case then we should probably delete all the dead code related 
> to it and deprecate the public API's for it right?
> Dead code I'm talking about:
> 1. Task class: skipping, skipRanges, writeSkipRecs
> 2. MapTask class:  SkippingRecordReader inner class
> 3. ReduceTask class: SkippingReduceValuesIterator inner class
> 4. Tests: TestBadRecords
> Public API:
> 1. SkipBadRecords class

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to