[
https://issues.apache.org/jira/browse/MAPREDUCE-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511028#comment-13511028
]
Harsh J commented on MAPREDUCE-4594:
------------------------------------
I notice no objects (such as an attempt context object) being passed into the
setup and cleanup methods you wish to introduce here. Without that how is this
helpful?
In my mind I was viewing your proposal as a step over writing "extends
Configurable" for new API partitioner implementations, when one needs at least
the Configuration object instance to pull values out from.
Plus, the ordering of these calls matter, so tests are absolutely necessary if
we do not want to regress by accident in future.
> Add init/shutdown methods to mapreduce Partitioner
> --------------------------------------------------
>
> Key: MAPREDUCE-4594
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4594
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: trunk
> Reporter: Radim Kolar
> Attachments: partitioner1.txt
>
>
> The Partitioner supports only the Configurable API, which can be used for
> basic init in setConf(). Problem is that there is no shutdown function.
> I propose to use standard setup() cleanup() functions like in mapper /
> reducer.
> Use case is that I need to start and stop spring context and datagrid client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
