[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538971#comment-13538971
 ] 

Arun C Murthy edited comment on MAPREDUCE-4896 at 12/23/12 4:55 AM:
--------------------------------------------------------------------

Looks like this needs more work - I still see a large stack trace (admittedly 
without the NPE). We should swallow the trace and print a simple, user-friendly 
'Unknown queue' message with an appropriate error code (-1).

Also, a test case (similar to TestCLI) would be useful to check the error msg, 
return code etc.

It's a stylistic issue, but I feel the previous change to ClientRMService 
(early exit) is much more clear.
                
      was (Author: acmurthy):
    Looks like this needs much work work - I still see a large stack trace 
(admittedly without the NPE). We should swallow the trace and print a simple, 
user-friendly 'Unknown queue' message with an appropriate error code (-1).

Also, a test case (similar to TestCLI) would be useful to check the error msg, 
return code etc.

It's a stylistic issue, but I feel the previous change to ClientRMService 
(early exit) is much more clear.
                  
> "mapred queue -info" spits out ugly exception when queue does not exist
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4896
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4896
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client, scheduler
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-4896-1.patch, MAPREDUCE-4896.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to