[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549964#comment-13549964
 ] 

Karthik Kambatla commented on MAPREDUCE-4925:
---------------------------------------------

Hi Harsh

Thanks for taking a look. I created MAPREDUCE-4930 for this to follow your 
suggestion, but two patches for branch-1 seems like an overkill. Here is what I 
propose:
# Re-open MAPREDUCE-4678, and commit the patch there to branch-2 and branch-0.23
# This JIRA (MAPREDUCE-4925) fixes the bug introduced by 4678.
# In MAPREDUCE-4930, we can backport the above two in a single patch.

This way, we can make sure the commits are same on trunk, branch-2 and 
branch-0.23, so that all merges and stuff work well. We need not introduce a 
bug unnecessarily in branch-1, the example code and the entire code base is 
different, and it is in maintenance mode.

Hopefully, this is reasonable. Let me know if you think otherwise.
                
> The pentomino option parser may be buggy
> ----------------------------------------
>
>                 Key: MAPREDUCE-4925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: examples
>    Affects Versions: 1.1.1, 2.0.2-alpha, 0.23.5
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: mr-4925-branch-0.23.patch, mr-4925-branch2.patch, 
> mr-4925.patch, mr-4925.patch, mr-4925-trunk.patch
>
>
> MAPREDUCE-4678 adds an easier way to specify arguments to Pentomino, although 
> it seems to carry a bug when fetching values.
> This JIRA is for fixing that on trunk and backporting the full fix onto other 
> branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to