[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alejandro Abdelnur updated MAPREDUCE-4808:
------------------------------------------

    Attachment: MR-4808.patch

I've taken the liberty to tweak the patch a bit based the last comments in the 
JIRA.

* removed pluggability via config of the MergeManager
* Shuffle has a protected createMergeManager() method
* MergeManager is annotated as Private
* Kept MergeManagerPlugin interface
* Removed MergeManagerPlugin.Context
* MergeManagerPlugin interface annotated as Private

These changes avoid having an extra know (the MergeManager class) in the 
config. Keep the MergeManager owned by the Shuffle class. The interface allows, 
for impls like Jerry's and Asokan's, for alternate implementations.

Asokan, Arun, Chris?
                
> Refactor MapOutput and MergeManager to facilitate reuse by Shuffle 
> implementations
> ----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4808
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4808
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>            Reporter: Arun C Murthy
>            Assignee: Mariappan Asokan
>         Attachments: COMBO-mapreduce-4809-4812-4808.patch, 
> mapreduce-4808.patch, mapreduce-4808.patch, mapreduce-4808.patch, 
> mapreduce-4808.patch, mapreduce-4808.patch, mapreduce-4808.patch, 
> mapreduce-4808.patch, MergeManagerPlugin.pdf, MR-4808.patch
>
>
> Now that Shuffle is pluggable (MAPREDUCE-4049), it would be convenient for 
> alternate implementations to be able to reuse portions of the default 
> implementation. 
> This would come with the strong caveat that these classes are LimitedPrivate 
> and Unstable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to