[
https://issues.apache.org/jira/browse/MAPREDUCE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561105#comment-13561105
]
Siddharth Seth commented on MAPREDUCE-4838:
-------------------------------------------
Took a quick look. This patch looks better but still needs some fixes.
- Unit tests should use the new properties defined in MRJobConfig.*
- In case of Reduce tasks, the container host doesn't need to be resolved (or
in the case where dataLocalHosts is empty)
- The null check is still required in the history events - since these values
don't need to be set.
- TaskAttemptImpl has a repeated dataLocalHosts assignment
- RMContainerAllocator has an unused import
- Formatting fix in TestJobImpl (patch line 377)
- Since resolveHosts has been changed to work with a hashSet - TaskAttemptImpl
itself could store this. Instead of iterating over an array to match the
container host.
Most of the test changes look good as well. Need to take a better look at some
of them though. Thanks.
> Add extra info to JH files
> --------------------------
>
> Key: MAPREDUCE-4838
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4838
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Zhijie Shen
> Attachments: MAPREDUCE-4838_1.patch, MAPREDUCE-4838_2.patch,
> MAPREDUCE-4838.patch
>
>
> It will be useful to add more task-info to JH for analytics.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
