[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573504#comment-13573504 ]
Hudson commented on MAPREDUCE-4822: ----------------------------------- Integrated in Hadoop-Mapreduce-trunk #1337 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1337/]) MAPREDUCE-4822. Unnecessary conversions in History Events. Contributed by Chu Tong (Revision 1443257) Result = SUCCESS jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1443257 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/MapAttemptFinishedEvent.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/ReduceAttemptFinishedEvent.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/TaskAttemptFinishedEvent.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/TaskFinishedEvent.java > Unnecessary conversions in History Events > ----------------------------------------- > > Key: MAPREDUCE-4822 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4822 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: jobhistoryserver > Affects Versions: 0.23.4 > Reporter: Robert Joseph Evans > Assignee: Chu Tong > Priority: Trivial > Labels: patch > Fix For: 2.0.3-alpha, 0.23.7 > > Attachments: MAPREDUCE-4822.patch > > > There are a number of conversions in the Job History Event classes that are > totally unnecessary. It appears that they were originally used to convert > from the internal avro format, but now many of them do not pull the values > from the avro they store them internally. > For example: > {code:title=TaskAttemptFinishedEvent.java} > /** Get the task type */ > public TaskType getTaskType() { > return TaskType.valueOf(taskType.toString()); > } > {code} > The code currently is taking an enum, converting it to a string and then > asking the same enum to convert it back to an enum. If java work properly > this should be a noop and a reference to the original taskType should be > returned. > There are several places that a string is having toString called on it, and > since strings are immutable it returns a reference to itself. > The various ids are not immutable and probably should not be changed at this > point. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira